This repository was archived by the owner on Jan 22, 2025. It is now read-only.
Add ledger-tool bigtable upload loop #26030
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
cc @artburkart |
artburkart
reviewed
Jun 17, 2022
CriesofCarrots
added
the
automerge
mergify bot
pushed a commit
that referenced
this pull request
Jun 17, 2022
* Add ledger-tool bigtable upload loop * Limit range on caller side, switch to while loop, and remove now-obsolete option (cherry picked from commit 2866ca4)
mergify bot
added a commit
that referenced
this pull request
Jun 17, 2022
* Add ledger-tool bigtable upload loop * Limit range on caller side, switch to while loop, and remove now-obsolete option (cherry picked from commit 2866ca4) Co-authored-by: Tyera Eulberg <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
#24716 added a configurable limit to the number of blocks that
solana_ledger::bigtable_upload::upload_confirmed_blockschecks at a time. However, it neglected to updatesolana-ledger-tool.Summary of Changes
Add a loop to
solana-ledger-tool bigtable uploadso that the upload service iterates through the entire requested range, instead of stopping at the first limit.Fixes #26023