This repository was archived by the owner on Jan 22, 2025. It is now read-only.
Add replay invalidator scaffolding upstream #31567
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #31567 +/- ##
=========================================
- Coverage 81.9% 81.8% -0.1%
=========================================
Files 737 737
Lines 205985 205990 +5
=========================================
- Hits 168718 168704 -14
- Misses 37267 37286 +19 |
bw-solana
requested review from
KirillLykov,
apfitzge,
ilya-bobyr,
steviez and
t-nelson
t-nelson
suggested changes
May 10, 2023
Contributor
t-nelson
left a comment
t-nelson
left a comment
There was a problem hiding this comment.
some general concerns about the level of public exposure to advtest described below
bw-solana
force-pushed
the
replay_invalidator_scaffold
branch
from
cdf03fa to
9e9df21
Compare
wen-coding
pushed a commit
to wen-coding/solana
that referenced
this pull request
May 18, 2023
* Add replay invalidator scaffolding upstream
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Integration between invalidator and upstream can be challenging if there are many merge conflicts to resolve. Pushing some vestigial code upstream will limit the number of collisions.
See https://github.com/solana-labs/invalidator/pull/20 for some additional context. Note this is one of a few strategies being explored to minimize integration burden between repos - open to recommendations
Summary of Changes
GeneratorConfigand plumbing from Validator --> TPU (doesn't actually do anything)Addgenerate-blocks-with-accountscmd line arg (doesn't actually do anything)Addtest_mainnet_beta_cluster_type_generator(marked as ignore)