loaded accounts data size cost does not apply to vote transaction

[tao-stones]

Problem

It is a bug to include Loaded_accounts_data_size_cost to Simple Vote transaction; if feature gate #30657 is activated, each vote transaction will have ~16K more CUs (vote tx does not have compute_budget instructions), therefore resulting less votes in block. Ideally vote should have stable cost, if not static.

It needs to be BP

Summary of Changes

• sum vote cost differently.

Fixes #

[AshwinSekar]

lgtm, but i don't have enough context on the loaded accounts data size cost to approve.

[apfitzge]

Does this need to be feature-gated since we're changing to cost of votes on testnet where the feature is already active?

[codecov]

Codecov Report

Merging #33235 (5401a22) into master (525e59f) will increase coverage by 0.0%.
Report is 4 commits behind head on master.
The diff coverage is 100.0%.

@@           Coverage Diff           @@
##           master   #33235   +/-   ##
=======================================
  Coverage    81.9%    81.9%           
=======================================
  Files         790      790           
  Lines      214213   214246   +33     
=======================================
+ Hits       175589   175646   +57     
+ Misses      38624    38600   -24     

[tao-stones]

Does this need to be feature-gated since we're changing to cost of votes on testnet where the feature is already active?

No that feature gate #30657 was blocked, not activated anyway yet. Hope to bp this fix to everywhere before that feature is unblocked.

[t-nelson]

sgtm!

[tao-stones]

turns out no need to back port it - relevant logics it fixes were not back ported.