This repository was archived by the owner on Jan 22, 2025. It is now read-only.
perf(sdk): Make Poseidon module optional to reduce default build times #33474
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Hey! Have there been any progress on this PR yet? The CI seems to fail. |
github-actions
bot
added
the
stale
Contributor
Author
|
@samkim-crypto Sorry for late reaction! Now CI should be passing. |
github-actions
bot
removed
the
stale
People report increased build times of Solana SDK (Lightprotocol/light-poseidon#31) after Poseidon syscall was merged (#32680). Not every Solana developer is going to need the Poseidon syscall. It's mostly meant fot ZK-related applications and protocols, so the SDK functionality related to Poseidon can be optionally enabled there. Therefore, hide the Poseidon functionality behind the `poseidon` feature flag.
github-actions
bot
added
the
stale
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
People report increased build times of Solana SDK (Lightprotocol/light-poseidon#31) after Poseidon syscall was merged (#32680).
Not every Solana developer is going to need the Poseidon syscall. It's mostly meant fot ZK-related applications and protocols, so the SDK functionality related to Poseidon can be optionally enabled there.
Therefore, hide the Poseidon functionality behind the
poseidonfeature flag.