This repository was archived by the owner on Jan 22, 2025. It is now read-only.
Removes unnecessary borrow #33539
Merged
Removes unnecessary borrow #33539
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apfitzge
approved these changes
Oct 5, 2023
Contributor
apfitzge
left a comment
apfitzge
left a comment
There was a problem hiding this comment.
Unlike std::fs:read_dir, fs_err::read_dir takes an Into<PathBuf>.
So by referencing here, we were cloning our PathBuf; removing the reference gets rid of that cloning.
brooksprumo
added
the
automerge
mergify
bot
removed
the
automerge
Contributor
|
automerge label removed due to a CI failure |
mergify bot
pushed a commit
that referenced
this pull request
Oct 5, 2023
(cherry picked from commit e0091d6)
brooksprumo
added a commit
that referenced
this pull request
Oct 5, 2023
(cherry picked from commit e0091d6) Co-authored-by: Brooks <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
There's an unnecessary borrow that next-nightly clippy complains about. It needs to be resolved to upgrade the nightly Rust version.
Summary of Changes
Remove the unnecessary borrow.