This repository was archived by the owner on Jan 22, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
Update hashes per tick with feature gates #33600
Merged
Merged
+156
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 9, 2023
Codecov Report
@@ Coverage Diff @@
## master #33600 +/- ##
=========================================
- Coverage 81.8% 81.7% -0.1%
=========================================
Files 806 807 +1
Lines 217477 218329 +852
=========================================
+ Hits 178026 178531 +505
- Misses 39451 39798 +347 |
t-nelson
reviewed
Oct 11, 2023
t-nelson
previously approved these changes
Oct 11, 2023
Contributor
t-nelson
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
r+ feature gate string udpates
bp to 1.17?
Contributor
Author
Yep, I can backport |
Co-authored-by: Trent Nelson <[email protected]>
387da48 to
34d7336
Compare
t-nelson
approved these changes
Oct 11, 2023
mergify bot
pushed a commit
that referenced
this pull request
Oct 11, 2023
* Update hashes per tick with feature gates (cherry picked from commit b36d051)
bw-solana
added a commit
that referenced
this pull request
Oct 11, 2023
…#33661) Update hashes per tick with feature gates (#33600) * Update hashes per tick with feature gates (cherry picked from commit b36d051) Co-authored-by: Brennan <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Add 5 additional feature gates to be able to gradually ramp up required hashes per tick to keep validators busier based on analysis in https://docs.google.com/spreadsheets/d/1NDJZiSFxqbVIi0jn-7I7MrYN2lqP4j9GePZdyPZ1fhI/edit#gid=1060803070
Summary of Changes
Current hashes per tick is at 2M. Add features to step this up on epoch boundaries to: