This repository was archived by the owner on Jan 22, 2025. It is now read-only.
[zk-token-sdk] Limit max seed length for key derivations #33700
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #33700 +/- ##
=======================================
Coverage 81.8% 81.8%
=======================================
Files 806 806
Lines 218058 218120 +62
=======================================
+ Hits 178415 178473 +58
- Misses 39643 39647 +4 |
samkim-crypto
added
v1.17
joncinque
reviewed
Oct 20, 2023
Contributor
joncinque
left a comment
joncinque
left a comment
There was a problem hiding this comment.
R+ with nits addressed
Co-authored-by: Jon Cinque <[email protected]>
joncinque
reviewed
Oct 20, 2023
Contributor
joncinque
left a comment
joncinque
left a comment
There was a problem hiding this comment.
Sorry, just a couple more so that it'll pass CI
| return Err(AuthenticatedEncryptionError::SeedLengthTooShort.into()); | ||
| } | ||
| if seed.len() > MAXIMUM_SEED_LEN { | ||
| return Err(AuthenticatedEncryptionError::SeedLengthTooLarge.into()); |
Contributor
There was a problem hiding this comment.
Oh sorry, you'll also need this!
Suggested change
| return Err(AuthenticatedEncryptionError::SeedLengthTooLarge.into()); | |
| return Err(AuthenticatedEncryptionError::SeedLengthTooLong.into()); |
| return Err(ElGamalError::SeedLengthTooShort); | ||
| } | ||
| if seed.len() > MAXIMUM_SEED_LEN { | ||
| return Err(ElGamalError::SeedLengthTooLarge); |
Contributor
There was a problem hiding this comment.
Suggested change
| return Err(ElGamalError::SeedLengthTooLarge); | |
| return Err(ElGamalError::SeedLengthTooLong); |
joncinque
approved these changes
Oct 20, 2023
mergify bot
pushed a commit
that referenced
this pull request
Oct 20, 2023
* limit max seed length for elgamal keypairs * limit max seed length for authenticated encryption keys * Apply suggestions from code review Co-authored-by: Jon Cinque <[email protected]> * rename `SeedLengthTooLarge` to `SeedLengthTooLong` --------- Co-authored-by: Jon Cinque <[email protected]> (cherry picked from commit dd2b1bb)
samkim-crypto
added a commit
that referenced
this pull request
Oct 20, 2023
…port of #33700) (#33795) [zk-token-sdk] Limit max seed length for key derivations (#33700) * limit max seed length for elgamal keypairs * limit max seed length for authenticated encryption keys * Apply suggestions from code review Co-authored-by: Jon Cinque <[email protected]> * rename `SeedLengthTooLarge` to `SeedLengthTooLong` --------- Co-authored-by: Jon Cinque <[email protected]> (cherry picked from commit dd2b1bb) Co-authored-by: samkim-crypto <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
#33508
Summary of Changes
Add a maximum length (2^16 bytes, which should be plenty for any practical usecase) check on the maximum seed length for ElGamal and AES keypairs.
Fixes #