This repository was archived by the owner on Jan 22, 2025. It is now read-only.
remove redundant pubkey update record #33722
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
behzadnouri
previously approved these changes
Oct 16, 2023
Codecov Report
@@ Coverage Diff @@
## master #33722 +/- ##
=======================================
Coverage 81.8% 81.8%
=======================================
Files 806 806
Lines 217854 217851 -3
=======================================
+ Hits 178213 178248 +35
+ Misses 39641 39603 -38 |
behzadnouri
approved these changes
Oct 17, 2023
mergify bot
pushed a commit
that referenced
this pull request
Oct 17, 2023
* remove redundant pubkey update record * from became unused, so removed from all process_pull_response() calls (cherry picked from commit 6efc7ec)
mergify bot
added a commit
that referenced
this pull request
Oct 17, 2023
…3735) remove redundant pubkey update record (#33722) * remove redundant pubkey update record * from became unused, so removed from all process_pull_response() calls (cherry picked from commit 6efc7ec) Co-authored-by: Greg Cusack <[email protected]>
behzadnouri
added a commit
to behzadnouri/solana
that referenced
this pull request
Oct 17, 2023
Following: solana-labs#33722 from pubkey in PullResponse is no longer used in processing pull-responses and as a result the code can be simplified.
behzadnouri
added a commit
to behzadnouri/solana
that referenced
this pull request
Oct 17, 2023
Following: solana-labs#33722 from pubkey in PullResponse is no longer used in processing pull-responses and as a result the code can be simplified.
behzadnouri
added a commit
that referenced
this pull request
Oct 18, 2023
Following: #33722 from pubkey in PullResponse is no longer used in processing pull-responses and so the code can be simplified.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
a validator uses the pubkey of the sender of a
PullResponseto update the sender's liveliness in itsCrds::table. But this is redundant because eventually the sender of thePullResponsewill be the origin of someCrdsValuethat the validator will receive. So the validator is essentially updating the liveliness twice.Summary of Changes
Eliminated updating the sender of a
PullResponse's livelinessFixes #