This repository was archived by the owner on Jan 22, 2025. It is now read-only.
program error: add ArithmeticOverflow
#33767
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #33767 +/- ##
=========================================
- Coverage 81.8% 81.8% -0.1%
=========================================
Files 766 807 +41
Lines 209094 217939 +8845
=========================================
+ Hits 171138 178304 +7166
- Misses 37956 39635 +1679 |
buffalojoec
force-pushed
the
program-error-add-arithmetic-overflow
branch
from
1a78c26 to
abfd523
Compare
buffalojoec
force-pushed
the
program-error-add-arithmetic-overflow
branch
from
abfd523 to
ed7ad04
Compare
mergify bot
pushed a commit
that referenced
this pull request
Oct 20, 2023
(cherry picked from commit 37d093a)
buffalojoec
pushed a commit
that referenced
this pull request
Oct 20, 2023
…33779) program error: add `ArithmeticOverflow` (#33767) (cherry picked from commit 37d093a) Co-authored-by: Joe C <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
We often write error variants to handle arithmetic overflow in the Solana Program Library because the error
ArithmeticOverflowfromsolana_sdk::instruction::InstructionErrordoes not have a counterpart insolana_program::program_error::ProgramError.Summary of Changes
Add the
ArithmeticOverflowerror variant tosolana_program::program_error::ProgramError.Note: Marked as draft until rebased onto #33766