Skip to content
This repository was archived by the owner on Jan 22, 2025. It is now read-only.

Conversation

@pgarg66
Copy link
Contributor

@pgarg66 pgarg66 commented Oct 21, 2023

Problem

WorkingSlot trait could be replaced with the global instance of ForkGrpah.

Summary of Changes

Use the global ForkGraph if it's available. Otherwise, use the provided WorkingSlot.
Updated unit tests.

Fixes #

@pgarg66 pgarg66 force-pushed the use-global-fork-graph branch from 61f8e0b to c03b38c Compare October 21, 2023 11:48
@pgarg66 pgarg66 marked this pull request as ready for review October 21, 2023 11:53
@pgarg66 pgarg66 force-pushed the use-global-fork-graph branch from f0583ba to 9f0c4b6 Compare October 21, 2023 15:34
@pgarg66 pgarg66 force-pushed the use-global-fork-graph branch 2 times, most recently from dfc4263 to 5a84a39 Compare October 23, 2023 21:02
@pgarg66 pgarg66 force-pushed the use-global-fork-graph branch from 5a84a39 to e8a4baa Compare October 24, 2023 22:45
@pgarg66 pgarg66 requested a review from Lichtso October 24, 2023 23:47
@codecov
Copy link

codecov bot commented Oct 24, 2023

Codecov Report

Merging #33806 (e8a4baa) into master (9ffbe2a) will decrease coverage by 0.1%.
The diff coverage is 87.5%.

@@            Coverage Diff            @@
##           master   #33806     +/-   ##
=========================================
- Coverage    81.9%    81.9%   -0.1%     
=========================================
  Files         809      809             
  Lines      217717   217692     -25     
=========================================
- Hits       178345   178309     -36     
- Misses      39372    39383     +11     

Copy link
Contributor

@Lichtso Lichtso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Title and description of the PR should be adjusted.

@pgarg66 pgarg66 changed the title Use program cache fork graph instead of WorkingSlot trait Use program cache fork graph in extract() Oct 25, 2023
@pgarg66 pgarg66 merged commit 78c31aa into solana-labs:master Oct 25, 2023
@pgarg66 pgarg66 deleted the use-global-fork-graph branch October 25, 2023 13:04
@pgarg66 pgarg66 added the v1.17 PRs that should be backported to v1.17 label Oct 25, 2023
mergify bot pushed a commit that referenced this pull request Oct 25, 2023
* Use program cache fork graph instead of WorkingSlot trait

* Fix deadlocked tests

* keep WorkingSlot trait for now

(cherry picked from commit 78c31aa)
mergify bot added a commit that referenced this pull request Oct 25, 2023
…#33862)

Use program cache fork graph in extract() (#33806)

* Use program cache fork graph instead of WorkingSlot trait

* Fix deadlocked tests

* keep WorkingSlot trait for now

(cherry picked from commit 78c31aa)

Co-authored-by: Pankaj Garg <[email protected]>
anwayde pushed a commit to firedancer-io/solana that referenced this pull request Nov 16, 2023
…labs#33806) (solana-labs#33862)

Use program cache fork graph in extract() (solana-labs#33806)

* Use program cache fork graph instead of WorkingSlot trait

* Fix deadlocked tests

* keep WorkingSlot trait for now

(cherry picked from commit 78c31aa)

Co-authored-by: Pankaj Garg <[email protected]>
anwayde pushed a commit to firedancer-io/solana that referenced this pull request Nov 16, 2023
…labs#33806) (solana-labs#33862)

Use program cache fork graph in extract() (solana-labs#33806)

* Use program cache fork graph instead of WorkingSlot trait

* Fix deadlocked tests

* keep WorkingSlot trait for now

(cherry picked from commit 78c31aa)

Co-authored-by: Pankaj Garg <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

v1.17 PRs that should be backported to v1.17

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants