This repository was archived by the owner on Jan 22, 2025. It is now read-only.
Do not prune cache entry if the runtime environment is different #34100
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
LoadedPrograms::prune()should not remove an old entry if the runtime environment has changed. The old entry could still be getting used to replay old slots (slots corresponding to the old environment).Summary of Changes
Check if the environment matches before pruning the old entry.
Fixes #