This repository was archived by the owner on Jan 22, 2025. It is now read-only.
cli: Hides the filler accounts args #34113
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brooksprumo
added
v1.16
brooksprumo
force-pushed
the
filler-accounts/hide-cli
branch
from
2d8291c to
6d1ad93
Compare
Contributor
Author
|
Jeff, requesting your review to ensure it's OK to hide these CLI args. Trent, requesting your review since it touches CLI. |
t-nelson
approved these changes
Nov 16, 2023
Contributor
t-nelson
left a comment
t-nelson
left a comment
There was a problem hiding this comment.
ideally we never would have exposed these to the production binaries in the first place
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #34113 +/- ##
=======================================
Coverage 81.9% 81.9%
=======================================
Files 812 812
Lines 219737 219739 +2
=======================================
+ Hits 180028 180054 +26
+ Misses 39709 39685 -24 |
mergify bot
pushed a commit
that referenced
this pull request
Nov 16, 2023
(cherry picked from commit b4c652e)
mergify bot
pushed a commit
that referenced
this pull request
Nov 16, 2023
(cherry picked from commit b4c652e)
This was referenced Nov 16, 2023
brooksprumo
added a commit
that referenced
this pull request
Nov 16, 2023
cli: Hides the filler accounts args (#34113) (cherry picked from commit b4c652e) Co-authored-by: Brooks <[email protected]>
brooksprumo
added a commit
that referenced
this pull request
Nov 16, 2023
cli: Hides the filler accounts args (#34113) (cherry picked from commit b4c652e) Co-authored-by: Brooks <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The CLI args for filler accounts are meant for testing/debugging only, and should not be used by regular validators.
(We're also likely going to remove the filler accounts entirely, so removing the CLI args is a good first step.)
Summary of Changes
Hide these args.