This repository was archived by the owner on Jan 22, 2025. It is now read-only.
v1.17: Fix - Bank::compute_active_feature_set() and Bank::apply_feature_activations() (backport of #34124)
#34136
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ctivations()` (#34124) * Moves modification of feature accounts from Bank::compute_active_feature_set() into Bank::apply_feature_activations(). * Renames allow_new_activations and newly_activated to include_pending and pending. * Fix test_compute_active_feature_set. (cherry picked from commit 6b85450)
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## v1.17 #34136 +/- ##
=======================================
Coverage 81.8% 81.8%
=======================================
Files 803 803
Lines 217911 217917 +6
=======================================
+ Hits 178347 178386 +39
+ Misses 39564 39531 -33 |
seanyoung
approved these changes
Nov 17, 2023
Contributor
seanyoung
left a comment
seanyoung
left a comment
There was a problem hiding this comment.
Thank you for asking me to review. Looks cleaner.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automatic backport of pull request #34124 done by Mergify.
Mergify commands and options
More conditions and actions can be found in the documentation.
You can also trigger Mergify actions by commenting on this pull request:
@Mergifyio refreshwill re-evaluate the rules@Mergifyio rebasewill rebase this PR on its base branch@Mergifyio updatewill merge the base branch into this PR@Mergifyio backport <destination>will backport this PR on<destination>branchAdditionally, on Mergify dashboard you can:
Finally, you can contact us on https://mergify.com