This repository was archived by the owner on Jan 22, 2025. It is now read-only.
Only compile bench_program_alu for x86_64 #34282
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #34282 +/- ##
=======================================
Coverage 81.9% 81.9%
=======================================
Files 819 819
Lines 219817 219817
=======================================
+ Hits 180130 180171 +41
+ Misses 39687 39646 -41 |
Lichtso
approved these changes
Nov 30, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Running
./ci/test-checks.shcurrently fails on mac arm64 because of the call tojit_compile(), which only supports x86_64.It would be helpful to be able to run these checks to completion on mac dev machines.
Summary of Changes
Add attribute to only compile bench on x86_64 and ignore the dead-code and unused-import warnings that result.