This repository was archived by the owner on Jan 22, 2025. It is now read-only.
replay: only vote on blocks with full last fec set #34294
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AshwinSekar
force-pushed
the
full-fec-fork-choice
branch
5 times, most recently
from
388d7bb to
9ddee53
Compare
t-nelson
reviewed
Dec 1, 2023
core/src/replay_stage.rs
Outdated
| Some((bank.parent_slot(), bank.parent_hash())), | ||
| ); | ||
| // If the block does not have at least 64 shreds in the last FEC set, mark | ||
| // it as duplicate, effectively removing it from fork choice. |
Contributor
There was a problem hiding this comment.
Suggested change
| // it as duplicate, effectively removing it from fork choice. | |
| // it as invalid, effectively removing it from fork choice. |
right? could be for reasons other than fuckery
wen-coding
reviewed
Dec 1, 2023
core/src/replay_stage.rs
Outdated
| ); | ||
| // If the block does not have at least 64 shreds in the last FEC set, mark | ||
| // it as duplicate, effectively removing it from fork choice. | ||
| let mut incomplete_last_fec_set = true; |
Contributor
There was a problem hiding this comment.
nit: you are checking for a specific size, so it's not incomplete_last_fec_set, it's last_fec_set_too_small or something along that line?
core/src/replay_stage.rs
Outdated
| bank.slot(), | ||
| u32::try_from(last_shred_index).expect("LAST_SHRED_IN_SLOT should be u32"), | ||
| )) { | ||
| if erasure_meta.total_shreds() >= 64 { |
Contributor
There was a problem hiding this comment.
We should probably get this constant from somewhere else depending on how the other PR is implemented.
| heaviest_subtree_fork_choice | ||
| .mark_fork_invalid_candidate(&(bank.slot(), bank.hash())); | ||
| } | ||
|
|
AshwinSekar
force-pushed
the
full-fec-fork-choice
branch
from
9ddee53 to
d94bed5
Compare
Contributor
Author
|
should be merged after #34330 |
behzadnouri
suggested changes
Dec 6, 2023
core/src/replay_stage.rs
Outdated
Comment on lines
2901
to
2902
| // If the block does not have at least 64 shreds in the last FEC set, mark | ||
| // it as invalid, effectively removing it from fork choice. |
Contributor
There was a problem hiding this comment.
This definitely needs a feature-gate.
Contributor
Author
There was a problem hiding this comment.
why? there is no bank hash change
Contributor
There was a problem hiding this comment.
what if 40% of the cluster mark it invalid and the other 60% vote on it?
Contributor
Author
There was a problem hiding this comment.
fair point 😅 - that specific scenario will work but 50/50 will kill us
will add a feature gate
behzadnouri
reviewed
Dec 6, 2023
core/src/replay_stage.rs
Outdated
| if let Some(last_shred_index) = slot_meta.last_index { | ||
| if let Ok(Some(erasure_meta)) = blockstore.erasure_meta(ErasureSetId::new( | ||
| bank.slot(), | ||
| u32::try_from(last_shred_index).expect("LAST_SHRED_IN_SLOT should be u32"), |
Contributor
There was a problem hiding this comment.
This does not look right. Are you using this as the fec_set_index?
AshwinSekar
force-pushed
the
full-fec-fork-choice
branch
from
d94bed5 to
859b748
Compare
AshwinSekar
force-pushed
the
full-fec-fork-choice
branch
from
859b748 to
4bbb8aa
Compare
github-actions
bot
added
the
stale
behzadnouri
removed
the
stale
github-actions
bot
added
the
stale
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
wider retransmitter set for last erasure batch
Summary of Changes
mark slot as invalid in fork choice if size < 64 shreds
Fixes #