Throttle unstaked quic streams for a given connection #34562
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #34562 +/- ##
=======================================
Coverage 81.8% 81.8%
=======================================
Files 820 820
Lines 221055 221094 +39
=======================================
+ Hits 180887 180980 +93
+ Misses 40168 40114 -54 |
lijunwangs
left a comment
lijunwangs
left a comment
There was a problem hiding this comment.
Changes looks good for me as the first rate limiter implementation.
pgarg66
added
v1.16
|
Backports to the stable branch are to be avoided unless absolutely necessary for fixing bugs, security issues, and perf regressions. Changes intended for backport should be structured such that a minimum effective diff can be committed separately from any refactoring, plumbing, cleanup, etc that are not strictly necessary to achieve the goal. Any of the latter should go only into master and ride the normal stabilization schedule. |
|
Backports to the beta branch are to be avoided unless absolutely necessary for fixing bugs, security issues, and perf regressions. Changes intended for backport should be structured such that a minimum effective diff can be committed separately from any refactoring, plumbing, cleanup, etc that are not strictly necessary to achieve the goal. Any of the latter should go only into master and ride the normal stabilization schedule. Exceptions include CI/metrics changes, CLI improvements and documentation updates on a case by case basis. |
* Throttle unstaked quic streams for a given connection * Fix interval duration check * move wait to handle_chunk * set max unistreams to 0 * drop new streams * cleanup * some more cleanup * fix tests * update test and stop code * fix bench-tps (cherry picked from commit 6bbd366)
* Throttle unstaked quic streams for a given connection * Fix interval duration check * move wait to handle_chunk * set max unistreams to 0 * drop new streams * cleanup * some more cleanup * fix tests * update test and stop code * fix bench-tps (cherry picked from commit 6bbd366)
| let packets = vec![vec![0u8; PACKET_DATA_SIZE]; num_expected_packets]; | ||
| assert!(client.send_data_batch(&packets).await.is_ok()); | ||
| for packet in packets { | ||
| let _ = client.send_data(&packet).await; |
There was a problem hiding this comment.
was the assertion dropped intentionally?
There was a problem hiding this comment.
Yes, the send_data can return error. So we can't assert on is_ok().
3 participants
Problem
We currently limit of concurrent unstaked QUIC streams. But the client can create unbounded number of streams over time by closing existing streams and creating new ones.
Summary of Changes
Track number of streams created in a connection
Once the limit is reached, wait till the next time interval before accepting new streams
Fixes #