This repository was archived by the owner on Jan 22, 2025. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
a related convo: https://discord.com/channels/428295358100013066/560503042458517505/1196572613523279942
Summary of Changes
return an error when the crate fails to publish
=> sometimes we receive reports about missing crates. I think we can detect these issues earlier and take appropriate actions (like re-publish or move to next tag)
use the check which is already in
cargo publishinstead of crate test=> I guess we use crate-test for ensuring the successful publishing of the next crate 🤔 maybe we can just retry
cargo publish. this command will tell us if anything goes wrong. (like dependences are not ready or building error)these are big changes to our existing publish pipeline. let me know what you think. btw, I will only backport it to v1.17. I think our v1.16 will never pass this one atm🙈