-
Notifications
You must be signed in to change notification settings - Fork 5.5k
Report lost_insertions metrics correctly #35191
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #35191 +/- ##
=========================================
- Coverage 81.6% 81.6% -0.1%
=========================================
Files 833 833
Lines 224827 224827
=========================================
- Hits 183523 183518 -5
- Misses 41304 41309 +5 |
|
Backports to the stable branch are to be avoided unless absolutely necessary for fixing bugs, security issues, and perf regressions. Changes intended for backport should be structured such that a minimum effective diff can be committed separately from any refactoring, plumbing, cleanup, etc that are not strictly necessary to achieve the goal. Any of the latter should go only into master and ride the normal stabilization schedule. |
|
Backports to the beta branch are to be avoided unless absolutely necessary for fixing bugs, security issues, and perf regressions. Changes intended for backport should be structured such that a minimum effective diff can be committed separately from any refactoring, plumbing, cleanup, etc that are not strictly necessary to achieve the goal. Any of the latter should go only into master and ride the normal stabilization schedule. Exceptions include CI/metrics changes, CLI improvements and documentation updates on a case by case basis. |
(cherry picked from commit 4b77ee5)
(cherry picked from commit 4b77ee5)
…35198) Report lost_insertions metrics correctly (#35191) (cherry picked from commit 4b77ee5) Co-authored-by: Ryo Onodera <[email protected]>
(cherry picked from commit 4b77ee5)
…35199) Report lost_insertions metrics correctly (#35191) (cherry picked from commit 4b77ee5) Co-authored-by: Ryo Onodera <[email protected]>
Problem
loaded-programs-cache-stats.lost_insertionsis wrongly reporting its value usinginsertions, introduced at #35026 (comment).Summary of Changes
Use correct
lost_insertionsinstead.Maybe worth to bp to v1.18 and v1.17?