Skip to content
This repository was archived by the owner on Jan 22, 2025. It is now read-only.

Conversation

@ryoqun
Copy link
Contributor

@ryoqun ryoqun commented Feb 14, 2024

Problem

loaded-programs-cache-stats.lost_insertions is wrongly reporting its value using insertions, introduced at #35026 (comment).

Summary of Changes

Use correct lost_insertions instead.

Maybe worth to bp to v1.18 and v1.17?

@codecov
Copy link

codecov bot commented Feb 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (897adb2) 81.6% compared to head (57e26dd) 81.6%.

Additional details and impacted files
@@            Coverage Diff            @@
##           master   #35191     +/-   ##
=========================================
- Coverage    81.6%    81.6%   -0.1%     
=========================================
  Files         833      833             
  Lines      224827   224827             
=========================================
- Hits       183523   183518      -5     
- Misses      41304    41309      +5     

@Lichtso Lichtso added v1.17 PRs that should be backported to v1.17 v1.18 PRs that should be backported to v1.18 labels Feb 14, 2024
@mergify
Copy link
Contributor

mergify bot commented Feb 14, 2024

Backports to the stable branch are to be avoided unless absolutely necessary for fixing bugs, security issues, and perf regressions. Changes intended for backport should be structured such that a minimum effective diff can be committed separately from any refactoring, plumbing, cleanup, etc that are not strictly necessary to achieve the goal. Any of the latter should go only into master and ride the normal stabilization schedule.

@mergify
Copy link
Contributor

mergify bot commented Feb 14, 2024

Backports to the beta branch are to be avoided unless absolutely necessary for fixing bugs, security issues, and perf regressions. Changes intended for backport should be structured such that a minimum effective diff can be committed separately from any refactoring, plumbing, cleanup, etc that are not strictly necessary to achieve the goal. Any of the latter should go only into master and ride the normal stabilization schedule. Exceptions include CI/metrics changes, CLI improvements and documentation updates on a case by case basis.

@ryoqun ryoqun merged commit 4b77ee5 into solana-labs:master Feb 14, 2024
mergify bot pushed a commit that referenced this pull request Feb 14, 2024
mergify bot pushed a commit that referenced this pull request Feb 14, 2024
ryoqun added a commit that referenced this pull request Feb 15, 2024
…35198)

Report lost_insertions metrics correctly (#35191)

(cherry picked from commit 4b77ee5)

Co-authored-by: Ryo Onodera <[email protected]>
ryoqun added a commit that referenced this pull request Feb 15, 2024
ryoqun added a commit that referenced this pull request Feb 16, 2024
…35199)

Report lost_insertions metrics correctly (#35191)

(cherry picked from commit 4b77ee5)

Co-authored-by: Ryo Onodera <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

v1.17 PRs that should be backported to v1.17 v1.18 PRs that should be backported to v1.18

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants