Skip to content
This repository was archived by the owner on Jan 22, 2025. It is now read-only.

Conversation

@diman-io
Copy link
Contributor

Problem

If the identity is changed on the validator using set-identity and there is a tower file for new identity, but the data in the file is outdated, then the validator terminates its operation.

Summary of Changes

Instead of terminating, the data for the tower will be taken from the current state of the cluster.

@codecov
Copy link

codecov bot commented Feb 19, 2024

Codecov Report

Attention: 8 lines in your changes are missing coverage. Please review.

Comparison is base (86b5f3c) 81.6% compared to head (c9f95dd) 81.6%.
Report is 4 commits behind head on master.

❗ Current head c9f95dd differs from pull request most recent head 8bff83a. Consider uploading reports for the commit 8bff83a to get more accurate results

Additional details and impacted files
@@            Coverage Diff            @@
##           master   #35229     +/-   ##
=========================================
- Coverage    81.6%    81.6%   -0.1%     
=========================================
  Files         834      833      -1     
  Lines      224827   224836      +9     
=========================================
- Hits       183517   183500     -17     
- Misses      41310    41336     +26     

@diman-io diman-io requested a review from AshwinSekar February 20, 2024 13:56
@AshwinSekar
Copy link
Contributor

thanks for the change, if you could rebase and fix the conflict i'm happy to merge it. #35173 just landed which is why there's a conflict.

@diman-io diman-io force-pushed the diman/pr/ignore-too-old-tower-error branch from ba31ede to a216acd Compare February 20, 2024 21:26
@diman-io
Copy link
Contributor Author

thanks for the change, if you could rebase and fix the conflict i'm happy to merge it. #35173 just landed which is why there's a conflict.

@AshwinSekar Done

@diman-io
Copy link
Contributor Author

I assume you will add v1.17 and v1.18

Copy link
Contributor

@AshwinSekar AshwinSekar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to fix the build warnings

@AshwinSekar AshwinSekar force-pushed the diman/pr/ignore-too-old-tower-error branch from 9bde34c to c9f95dd Compare February 21, 2024 02:30
@diman-io
Copy link
Contributor Author

Ohh, my bad. It was 1 a.m. here, copy-paste is evil. I checked build, but not clippy.

@AshwinSekar AshwinSekar force-pushed the diman/pr/ignore-too-old-tower-error branch from c9f95dd to 8bff83a Compare February 21, 2024 13:34
@AshwinSekar AshwinSekar requested a review from steviez February 21, 2024 16:36
Copy link
Contributor

@steviez steviez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@AshwinSekar AshwinSekar merged commit 531793b into solana-labs:master Feb 21, 2024
@AshwinSekar AshwinSekar added v1.17 PRs that should be backported to v1.17 v1.18 PRs that should be backported to v1.18 and removed need:merge-assist labels Feb 21, 2024
@mergify
Copy link
Contributor

mergify bot commented Feb 21, 2024

Backports to the stable branch are to be avoided unless absolutely necessary for fixing bugs, security issues, and perf regressions. Changes intended for backport should be structured such that a minimum effective diff can be committed separately from any refactoring, plumbing, cleanup, etc that are not strictly necessary to achieve the goal. Any of the latter should go only into master and ride the normal stabilization schedule.

@mergify
Copy link
Contributor

mergify bot commented Feb 21, 2024

Backports to the beta branch are to be avoided unless absolutely necessary for fixing bugs, security issues, and perf regressions. Changes intended for backport should be structured such that a minimum effective diff can be committed separately from any refactoring, plumbing, cleanup, etc that are not strictly necessary to achieve the goal. Any of the latter should go only into master and ride the normal stabilization schedule. Exceptions include CI/metrics changes, CLI improvements and documentation updates on a case by case basis.

mergify bot pushed a commit that referenced this pull request Feb 21, 2024
* validator: ignore too old tower error

* Update core/src/replay_stage.rs

Co-authored-by: Ashwin Sekar <[email protected]>

* remove redundant references

---------

Co-authored-by: Ashwin Sekar <[email protected]>
(cherry picked from commit 531793b)
mergify bot pushed a commit that referenced this pull request Feb 21, 2024
* validator: ignore too old tower error

* Update core/src/replay_stage.rs

Co-authored-by: Ashwin Sekar <[email protected]>

* remove redundant references

---------

Co-authored-by: Ashwin Sekar <[email protected]>
(cherry picked from commit 531793b)
mergify bot added a commit that referenced this pull request Feb 21, 2024
…5279)

validator: ignore too old tower error (#35229)

* validator: ignore too old tower error

* Update core/src/replay_stage.rs

Co-authored-by: Ashwin Sekar <[email protected]>

* remove redundant references

---------

Co-authored-by: Ashwin Sekar <[email protected]>
(cherry picked from commit 531793b)

Co-authored-by: DimAn <[email protected]>
AshwinSekar pushed a commit that referenced this pull request Feb 21, 2024
…5278)

validator: ignore too old tower error (#35229)

* validator: ignore too old tower error

* Update core/src/replay_stage.rs

Co-authored-by: Ashwin Sekar <[email protected]>

* remove redundant references

---------

Co-authored-by: Ashwin Sekar <[email protected]>
(cherry picked from commit 531793b)

Co-authored-by: DimAn <[email protected]>
jeffwashington pushed a commit to jeffwashington/solana that referenced this pull request Feb 27, 2024
* validator: ignore too old tower error

* Update core/src/replay_stage.rs

Co-authored-by: Ashwin Sekar <[email protected]>

* remove redundant references

---------

Co-authored-by: Ashwin Sekar <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

need:merge-assist v1.17 PRs that should be backported to v1.17 v1.18 PRs that should be backported to v1.18

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants