-
Notifications
You must be signed in to change notification settings - Fork 5.5k
validator: ignore too old tower error #35229
validator: ignore too old tower error #35229
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #35229 +/- ##
=========================================
- Coverage 81.6% 81.6% -0.1%
=========================================
Files 834 833 -1
Lines 224827 224836 +9
=========================================
- Hits 183517 183500 -17
- Misses 41310 41336 +26 |
|
thanks for the change, if you could rebase and fix the conflict i'm happy to merge it. #35173 just landed which is why there's a conflict. |
ba31ede to
a216acd
Compare
@AshwinSekar Done |
|
I assume you will add |
AshwinSekar
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
to fix the build warnings
9bde34c to
c9f95dd
Compare
|
Ohh, my bad. It was 1 a.m. here, copy-paste is evil. I checked build, but not clippy. |
Co-authored-by: Ashwin Sekar <[email protected]>
c9f95dd to
8bff83a
Compare
steviez
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
|
Backports to the stable branch are to be avoided unless absolutely necessary for fixing bugs, security issues, and perf regressions. Changes intended for backport should be structured such that a minimum effective diff can be committed separately from any refactoring, plumbing, cleanup, etc that are not strictly necessary to achieve the goal. Any of the latter should go only into master and ride the normal stabilization schedule. |
|
Backports to the beta branch are to be avoided unless absolutely necessary for fixing bugs, security issues, and perf regressions. Changes intended for backport should be structured such that a minimum effective diff can be committed separately from any refactoring, plumbing, cleanup, etc that are not strictly necessary to achieve the goal. Any of the latter should go only into master and ride the normal stabilization schedule. Exceptions include CI/metrics changes, CLI improvements and documentation updates on a case by case basis. |
* validator: ignore too old tower error * Update core/src/replay_stage.rs Co-authored-by: Ashwin Sekar <[email protected]> * remove redundant references --------- Co-authored-by: Ashwin Sekar <[email protected]> (cherry picked from commit 531793b)
* validator: ignore too old tower error * Update core/src/replay_stage.rs Co-authored-by: Ashwin Sekar <[email protected]> * remove redundant references --------- Co-authored-by: Ashwin Sekar <[email protected]> (cherry picked from commit 531793b)
…5279) validator: ignore too old tower error (#35229) * validator: ignore too old tower error * Update core/src/replay_stage.rs Co-authored-by: Ashwin Sekar <[email protected]> * remove redundant references --------- Co-authored-by: Ashwin Sekar <[email protected]> (cherry picked from commit 531793b) Co-authored-by: DimAn <[email protected]>
…5278) validator: ignore too old tower error (#35229) * validator: ignore too old tower error * Update core/src/replay_stage.rs Co-authored-by: Ashwin Sekar <[email protected]> * remove redundant references --------- Co-authored-by: Ashwin Sekar <[email protected]> (cherry picked from commit 531793b) Co-authored-by: DimAn <[email protected]>
* validator: ignore too old tower error * Update core/src/replay_stage.rs Co-authored-by: Ashwin Sekar <[email protected]> * remove redundant references --------- Co-authored-by: Ashwin Sekar <[email protected]>
Problem
If the identity is changed on the validator using
set-identityand there is a tower file for new identity, but the data in the file is outdated, then the validator terminates its operation.Summary of Changes
Instead of terminating, the data for the tower will be taken from the current state of the cluster.