Skip to content
This repository was archived by the owner on Jan 22, 2025. It is now read-only.

Conversation

@stevenbooke
Copy link

Problem

Trezor wallet is not supported.
#4911

Summary of Changes

Add support for the cli to use the wallet.

@mergify mergify bot added community Community contribution need:merge-assist labels Mar 7, 2024
@mergify mergify bot requested a review from a team March 7, 2024 19:59
@CriesofCarrots
Copy link
Contributor

Hi, @stevenbooke . We are no longer merging pull requests at this repository. Can you please re-open this pull request in the agave repo: https://github.com/anza-xyz/agave ?
Also, I took a glance at the code -- it's a large changeset for only one commit, and will be difficult to review. I'd recommend that you break it up into small, logically discrete commits. For example, separate out the addition of new modules or functions from changes that use them or otherwise modify existing apis.
Thank you!

@stevenbooke
Copy link
Author

Hi, @stevenbooke . We are no longer merging pull requests at this repository. Can you please re-open this pull request in the agave repo: https://github.com/anza-xyz/agave ? Also, I took a glance at the code -- it's a large changeset for only one commit, and will be difficult to review. I'd recommend that you break it up into small, logically discrete commits. For example, separate out the addition of new modules or functions from changes that use them or otherwise modify existing apis. Thank you!

Ok, I will go about doing that

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

community Community contribution need:merge-assist

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants