Skip to content
This repository was archived by the owner on Jan 22, 2025. It is now read-only.

Conversation

@aeyakovenko
Copy link
Member

Add a generic counter for AccountNotFound error, and a counter for when the error is from a transaction containing an Instruction::NewVote.

@aeyakovenko aeyakovenko requested review from garious and mvines July 15, 2018 20:09
@mvines
Copy link
Contributor

mvines commented Jul 15, 2018

INFLUX_RATE is going to be a problem here no? Ideally I think we'd get a ping into InfluxDB on every instance, not every 100.

@aeyakovenko
Copy link
Member Author

@mvines below 100 i was seeing a performance hit in the dynamic test. 100 means every 2 seconds we would see data with 50 validators, with 1000, it would be 10/second.

{
let option = bals.get_mut(&tx.from);
if option.is_none() {
if let Instruction::NewVote(_) = &tx.instruction {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Switch on the string to make it a two-liner?

Copy link
Member Author

@aeyakovenko aeyakovenko Jul 15, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@garious the counters are different statics, they aggregate state so we don't ping influx on every request. so we need one per event kind.

@garious garious merged commit 4631af5 into solana-labs:master Jul 16, 2018
vkomenda referenced this pull request in vkomenda/solana Aug 29, 2021
35359595 pushed a commit to 35359595/solana that referenced this pull request Apr 9, 2024
…-labs#633)

* corrected to not use hardcoded connections count for unstaked

* Fixed a math problem on max_unstaked_load_in_throttling_window

* Fixed a unit test failure
lijunwangs added a commit to lijunwangs/solana that referenced this pull request Apr 12, 2024
…-labs#633)

* corrected to not use hardcoded connections count for unstaked

* Fixed a math problem on max_unstaked_load_in_throttling_window

* Fixed a unit test failure

(cherry picked from commit 592107a)

# Conflicts:
#	streamer/src/nonblocking/quic.rs
#	streamer/src/nonblocking/stream_throttle.rs
lijunwangs added a commit to lijunwangs/solana that referenced this pull request Apr 17, 2024
…-labs#633)

* corrected to not use hardcoded connections count for unstaked

* Fixed a math problem on max_unstaked_load_in_throttling_window

* Fixed a unit test failure

(cherry picked from commit 592107a)

# Conflicts:
#	streamer/src/nonblocking/quic.rs
#	streamer/src/nonblocking/stream_throttle.rs
lijunwangs added a commit to lijunwangs/solana that referenced this pull request Apr 18, 2024
…-labs#633)

* corrected to not use hardcoded connections count for unstaked

* Fixed a math problem on max_unstaked_load_in_throttling_window

* Fixed a unit test failure
lijunwangs pushed a commit to lijunwangs/solana that referenced this pull request Apr 24, 2024
…(backport of solana-labs#633) (solana-labs#734)

corrected to not use hardcoded connections count for unstaked (solana-labs#633)
yihau pushed a commit that referenced this pull request Apr 26, 2024
…(backport of #633) (#734)

corrected to not use hardcoded connections count for unstaked (#633)
yihau pushed a commit that referenced this pull request May 7, 2024
…(backport of #633) (#762)

* corrected to not use hardcoded connections count for unstaked (#633)

Co-authored-by: Lijun Wang <[email protected]>
andreisilviudragnea pushed a commit to andreisilviudragnea/solana that referenced this pull request May 12, 2024
…(backport of solana-labs#633) (solana-labs#762)

* corrected to not use hardcoded connections count for unstaked (solana-labs#633)

Co-authored-by: Lijun Wang <[email protected]>
techiepriyansh pushed a commit to ChorusOne/solana that referenced this pull request Oct 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants