This repository was archived by the owner on Jan 22, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
counters for vote not found #633
Merged
garious
merged 1 commit into
solana-labs:master
from
aeyakovenko:counters_vote_not_found
Jul 16, 2018
Merged
counters for vote not found #633
garious
merged 1 commit into
solana-labs:master
from
aeyakovenko:counters_vote_not_found
Jul 16, 2018
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
|
Member
Author
|
@mvines below 100 i was seeing a performance hit in the dynamic test. 100 means every 2 seconds we would see data with 50 validators, with 1000, it would be 10/second. |
mvines
approved these changes
Jul 15, 2018
garious
reviewed
Jul 15, 2018
| { | ||
| let option = bals.get_mut(&tx.from); | ||
| if option.is_none() { | ||
| if let Instruction::NewVote(_) = &tx.instruction { |
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Switch on the string to make it a two-liner?
Member
Author
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@garious the counters are different statics, they aggregate state so we don't ping influx on every request. so we need one per event kind.
vkomenda
referenced
this pull request
in vkomenda/solana
Aug 29, 2021
Bumps [@babel/core](https://github.com/babel/babel/tree/HEAD/packages/babel-core) from 7.11.6 to 7.12.0. - [Release notes](https://github.com/babel/babel/releases) - [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md) - [Commits](https://github.com/babel/babel/commits/v7.12.0/packages/babel-core) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
35359595
pushed a commit
to 35359595/solana
that referenced
this pull request
Apr 9, 2024
…-labs#633) * corrected to not use hardcoded connections count for unstaked * Fixed a math problem on max_unstaked_load_in_throttling_window * Fixed a unit test failure
lijunwangs
added a commit
to lijunwangs/solana
that referenced
this pull request
Apr 12, 2024
…-labs#633) * corrected to not use hardcoded connections count for unstaked * Fixed a math problem on max_unstaked_load_in_throttling_window * Fixed a unit test failure (cherry picked from commit 592107a) # Conflicts: # streamer/src/nonblocking/quic.rs # streamer/src/nonblocking/stream_throttle.rs
lijunwangs
added a commit
to lijunwangs/solana
that referenced
this pull request
Apr 17, 2024
…-labs#633) * corrected to not use hardcoded connections count for unstaked * Fixed a math problem on max_unstaked_load_in_throttling_window * Fixed a unit test failure (cherry picked from commit 592107a) # Conflicts: # streamer/src/nonblocking/quic.rs # streamer/src/nonblocking/stream_throttle.rs
lijunwangs
added a commit
to lijunwangs/solana
that referenced
this pull request
Apr 18, 2024
…-labs#633) * corrected to not use hardcoded connections count for unstaked * Fixed a math problem on max_unstaked_load_in_throttling_window * Fixed a unit test failure
lijunwangs
pushed a commit
to lijunwangs/solana
that referenced
this pull request
Apr 24, 2024
…(backport of solana-labs#633) (solana-labs#734) corrected to not use hardcoded connections count for unstaked (solana-labs#633)
yihau
pushed a commit
that referenced
this pull request
May 7, 2024
…(backport of #633) (#762) * corrected to not use hardcoded connections count for unstaked (#633) Co-authored-by: Lijun Wang <[email protected]>
andreisilviudragnea
pushed a commit
to andreisilviudragnea/solana
that referenced
this pull request
May 12, 2024
…(backport of solana-labs#633) (solana-labs#762) * corrected to not use hardcoded connections count for unstaked (solana-labs#633) Co-authored-by: Lijun Wang <[email protected]>
techiepriyansh
pushed a commit
to ChorusOne/solana
that referenced
this pull request
Oct 2, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a generic counter for
AccountNotFounderror, and a counter for when the error is from a transaction containing anInstruction::NewVote.