Include shred version in gossip

[mvines]

Nodes with differing shred versions will not ingest each other's shreds, so ignore tvu/rpc nodes on gossip with differing shred versions when --wait-for-supermajority validator argument is used.

[sagar-solana]

Too much broke when you added the filter logic?

[mvines]

Too much broke when you added the filter logic?

Yeah, 🤕, so I scaled this back a little. Still trying to figure out what test_split_messages_packet_size is doing and why it's broken.

Pull request has been modified.

[sagar-solana]

test_split_messages_packet_size is badly named(sorry). It basically tries to make sure that if a single CrdsValue is so large that there isn't room to wrap it with a Vec and transmit it, then split_gossip_messages should drop that item. Looks like for some reason it's not dropping it. Possibly a bug in split_gossip_messages?

[mvines]

<= instead of < got test_split_messages_packet_size() working again.

[sagar-solana]

Ah okay, so the extra 2 bytes made it match exactly. I think that should be fine.

[codecov]

Codecov Report

Merging #7777 into master will decrease coverage by <.1%.
The diff coverage is 78.9%.

@@           Coverage Diff            @@
##           master   #7777     +/-   ##
========================================
- Coverage    81.8%   81.8%   -0.1%     
========================================
  Files         241     241             
  Lines       51075   51023     -52     
========================================
- Hits        41817   41759     -58     
- Misses       9258    9264      +6