Skip to content
This repository was archived by the owner on Jan 22, 2025. It is now read-only.

Plumb ability to handle duplicate shreds into shred insertion functions #7784

Merged
carllin merged 1 commit into from
Jan 14, 2020
Merged

Plumb ability to handle duplicate shreds into shred insertion functions #7784

carllin merged 1 commit into from
Jan 14, 2020

Conversation

@carllin
Copy link
Contributor

@carllin carllin commented Jan 14, 2020

Problem

Shred insertion doesn't have a mechanism to call a handler upon seeing a duplicate shred

Summary of Changes

Plumb ability to call a handler upon detection of duplicate shreds

Fixes #

@carllin carllin requested a review from sakridge January 14, 2020 02:45
@codecov
Copy link

codecov bot commented Jan 14, 2020

Codecov Report

Merging #7784 into master will increase coverage by <.1%.
The diff coverage is 100%.

@@           Coverage Diff            @@
##           master   #7784     +/-   ##
========================================
+ Coverage    81.9%   81.9%   +<.1%     
========================================
  Files         241     241             
  Lines       51070   51081     +11     
========================================
+ Hits        41841   41854     +13     
+ Misses       9229    9227      -2

sakridge
sakridge approved these changes Jan 14, 2020
View reviewed changes
Copy link
Contributor

@sakridge sakridge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@carllin carllin merged commit 721c437 into solana-labs:master Jan 14, 2020
This was referenced Aug 1, 2022
Open
Closed
Open
This was referenced Sep 21, 2022
Closed
Closed
Closed
This was referenced Sep 24, 2022
Open
Open
@snyk-bot snyk-bot mentioned this pull request Oct 3, 2022
Open
@Muqingluan Muqingluan mentioned this pull request Oct 18, 2022
Open
@snyk-bot snyk-bot mentioned this pull request Oct 18, 2022
Open
@adamlaska adamlaska mentioned this pull request Oct 19, 2022
Closed
@Digiminey Digiminey mentioned this pull request Oct 19, 2022
Open
@adamlaska adamlaska mentioned this pull request Oct 21, 2022
Closed
@snyk-bot snyk-bot mentioned this pull request Oct 26, 2022
Open
@Digiminey Digiminey mentioned this pull request Oct 26, 2022
Open
@adamlaska adamlaska mentioned this pull request Oct 26, 2022
Closed
@Muqingluan Muqingluan mentioned this pull request Nov 3, 2022
Open
@Digiminey Digiminey mentioned this pull request Nov 3, 2022
Open
This was referenced Nov 3, 2022
Closed
Closed
@Muqingluan Muqingluan mentioned this pull request Nov 5, 2022
Open
@Digiminey Digiminey mentioned this pull request Nov 5, 2022
Open
@adamlaska adamlaska mentioned this pull request Jan 11, 2024
Open
@adamlaska adamlaska mentioned this pull request Jan 25, 2024
Open
This was referenced Feb 7, 2024
Open
Open
@adamlaska adamlaska mentioned this pull request Feb 11, 2024
Open
@Digiminey Digiminey mentioned this pull request Feb 12, 2024
Open
@Digiminey Digiminey mentioned this pull request Mar 15, 2024
Open
@adamlaska adamlaska mentioned this pull request Mar 16, 2024
Open
This was referenced Mar 16, 2024
Open
Open
@adamlaska adamlaska mentioned this pull request Mar 22, 2024
Open
@Digiminey Digiminey mentioned this pull request Mar 22, 2024
Open
@q1blue q1blue mentioned this pull request Mar 23, 2024
Open
@balqaasem balqaasem mentioned this pull request Mar 24, 2024
Closed
@q1blue q1blue mentioned this pull request Mar 26, 2024
Open
@Digiminey Digiminey mentioned this pull request Mar 26, 2024
Open
@adamlaska adamlaska mentioned this pull request Mar 27, 2024
Open
@q1blue q1blue mentioned this pull request Mar 27, 2024
Open
@Digiminey Digiminey mentioned this pull request Apr 6, 2024
Open
@adamlaska adamlaska mentioned this pull request Apr 6, 2024
Open
@q1blue q1blue mentioned this pull request Apr 30, 2024
Open
@q1blue q1blue mentioned this pull request May 13, 2024
Open
@Digiminey Digiminey mentioned this pull request May 13, 2024
Open
@adamlaska adamlaska mentioned this pull request May 14, 2024
Open
This was referenced May 22, 2024
Open
Open
This was referenced Oct 10, 2024
Open
Open
Open
@q1blue q1blue mentioned this pull request Oct 21, 2024
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@sakridge sakridge sakridge approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@carllin @sakridge