This repository was archived by the owner on Jan 22, 2025. It is now read-only.
Remove accounts hack and correctly restore accounts store counts #8569
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sakridge
force-pushed
the
remove-accounts-hack
branch
2 times, most recently
from
d792dc3 to
2dac055
Compare
Codecov Report
@@ Coverage Diff @@
## master #8569 +/- ##
========================================
Coverage ? 80%
========================================
Files ? 256
Lines ? 55779
Branches ? 0
========================================
Hits ? 44660
Misses ? 11119
Partials ? 0 |
sakridge
force-pushed
the
remove-accounts-hack
branch
from
2dac055 to
33cc48a
Compare
Contributor
|
I still get a bank hash verification error when I:
|
ryoqun
reviewed
Mar 3, 2020
sakridge
force-pushed
the
remove-accounts-hack
branch
from
33cc48a to
4ab8ec1
Compare
ryoqun
reviewed
Mar 3, 2020
sakridge
force-pushed
the
remove-accounts-hack
branch
from
4ab8ec1 to
0afedaa
Compare
Contributor
Contributor
Author
Yea, if you can take this over, that would be great. |
sakridge
force-pushed
the
remove-accounts-hack
branch
from
0afedaa to
d25ab46
Compare
sakridge
force-pushed
the
remove-accounts-hack
branch
from
d25ab46 to
5170739
Compare
mergify bot
pushed a commit
that referenced
this pull request
Mar 4, 2020
* Remove accounts hack and correctly restore append-vec counts * Add test (cherry picked from commit b084c1d)
solana-grimes
pushed a commit
that referenced
this pull request
Mar 4, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Hack introduced to fix accounts code from cleaning up needed stores after they are recovered from a snapshot.
Summary of Changes
Restore all accounts versions in the append-vecs to prevent shielded accounts from being cleaned up.
Fixes #