This repository was archived by the owner on Jan 22, 2025. It is now read-only.
cli: Add commitment flag to vote-account and validators commands
#8597
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #8597 +/- ##
========================================
- Coverage 80.0% 80.0% -0.1%
========================================
Files 256 256
Lines 55727 55746 +19
========================================
- Hits 44609 44608 -1
- Misses 11118 11138 +20 |
Contributor
|
A more verbose PR description would be nice. |
Contributor
|
Also confused about the use of "commitment" in the title and "confirmed" elsewhere |
Contributor
Author
|
I'm just using, and remaining consistent with the terminology in the code. Makes for an easier search and replace later |
mergify bot
pushed a commit
that referenced
this pull request
Mar 4, 2020
(cherry picked from commit abf33b3)
This was referenced Feb 4, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes you want
--confirmed, sometimes no.