Skip to content

Conversation

@xuan-cao-swi
Copy link
Contributor

Description

As open-telemetry/opentelemetry-ruby-contrib#682 merged, no need this logic so remove them. Although, for RUBY 2.7, still need to manual set the obfuscate for instrumentation if needed.

e.g.

SolarWindsAPM::OTelConfig.initialize_with_config do |config|
  config["OpenTelemetry::Instrumentation::Dalli"] = {db_statement: :obfuscate}
  config["OpenTelemetry::Instrumentation::Mysql2"] = {db_statement: :obfuscate}
  config["OpenTelemetry::Instrumentation::PG"] = {db_statement: :obfuscate}
end

@xuan-cao-swi xuan-cao-swi requested a review from a team as a code owner January 2, 2024 19:13
Copy link
Contributor

@cheempz cheempz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @xuan-cao-swi!

@xuan-cao-swi xuan-cao-swi merged commit 65c5a43 into main Jan 3, 2024
@xuan-cao-swi xuan-cao-swi deleted the NH-64310 branch January 3, 2024 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants