Refactor: Rename loading to _loading and optimize createResource logic to prevent conflicts and improve resource management.
#2533
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 0223e3c The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
dennev
changed the title
createResource with improved inspection and serialization logic
Pull Request Test Coverage Report for Build 17024021319Details
💛 - Coveralls |
Open
2 tasks
iacore
reviewed
Aug 15, 2025
| p = new Promise(resolve => { | ||
| setTimeout(() => { | ||
| resolve(temp.then(val => handleResolvedValue(val, ctx, id))); | ||
| }, 300); // A safe number that won't throw an error. |
There was a problem hiding this comment.
I've summarized it in #2534 and solidjs/solid-start#1941 (comment), if you're interested.
I apologize for the incorrect review request, I sent a review because I thought I had solved the problem in another way, but it wasn't feasible. Please forget about it.
There was a problem hiding this comment.
@iacore I fixed the issue. You can check it out
dennev
force-pushed
the
fix/ssr-createResource
branch
3 times, most recently
from
4c8363e to
8b0f96e
Compare
dennev
changed the title
createResource with improved inspection and serialization logic
|
This commit is a proposal and is being submitted so that it can be part of some option. I understand people's concerns about timeouts, and I've summarized my considerations here. |
dennev
force-pushed
the
fix/ssr-createResource
branch
2 times, most recently
from
16b2e69 to
e66ebc1
Compare
|
I solved it by overriding loading. |
dennev
force-pushed
the
fix/ssr-createResource
branch
from
e66ebc1 to
d3f5257
Compare
dennev
changed the title
createResource
dennev
force-pushed
the
fix/ssr-createResource
branch
3 times, most recently
from
68c3e98 to
9fa4ef9
Compare
dennev
changed the title
createResourceread.loading with _loading to avoid variable conflicts and restructure resource handling logic in createResource
dennev
force-pushed
the
fix/ssr-createResource
branch
from
9fa4ef9 to
f0186ad
Compare
dennev
changed the title
read.loading with _loading to avoid variable conflicts and restructure resource handling logic in createResourceloading to _loading and optimize createResource logic to prevent conflicts and improve resource management.
dennev
force-pushed
the
fix/ssr-createResource
branch
from
f0186ad to
6e43f96
Compare
… logic for improved conflict prevention and resource management.
dennev
force-pushed
the
fix/ssr-createResource
branch
from
6e43f96 to
0223e3c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Address issue by replacing
loadingwith_loadingto avoid variable conflicts and restructure resource handling logic increateResourceIt also addresses the specific error in another issue(#2132).
How did you test this change?
Try testing the code in the issue or a short-running async function block with a
createResourceas a fetcher.