0.9.9 fails to build in FreeBSD

[5u623l20]

While trying to update the ports in FreeBSD I can see the following errors:

      | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  169 | "  -P          passthrough SSL connections if they cannot be split because of\n"
      | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
filter.c:1704:13: error: no member named 'user' in 'struct filter_rule'
 1704 |                 if (rule->user)
      |                     ~~~~  ^
filter.c:1705:15: error: no member named 'user' in 'struct filter_rule'
 1705 |                         free(rule->user);
      |                              ~~~~  ^
filter.c:1706:13: error: no member named 'desc' in 'struct filter_rule'
 1706 |                 if (rule->desc)
      |                     ~~~~  ^
filter.c:1707:15: error: no member named 'desc' in 'struct filter_rule'
 1707 |                         free(rule->desc);
      |                              ~~~~  ^
4 errors generated.
gmake[1]: *** [GNUmakefile:22: filter.o] Error 1

Can share the full build log if required.

But this commit c74ab03 doesn't seem to be aligned with the header file filter.h.

[sonertari]

Ah, you are right, it's the WITHOUT_USERAUTH switch. The following fixes the issue here. Can you test and report back please?

--- a/src/filter.c
+++ b/src/filter.c
@@ -1701,10 +1701,12 @@ err:
 			free(rule->sni);
 		if (rule->cn)
 			free(rule->cn);
+#ifndef WITHOUT_USERAUTH
 		if (rule->user)
 			free(rule->user);
 		if (rule->desc)
 			free(rule->desc);
+#endif /* !WITHOUT_USERAUTH */
 		if (rule->ip)
 			free(rule->ip);
 		free(rule);

[5u623l20]

Thanks for the quick patch. It's working as expected.

[sonertari]

Thanks for reporting, and in fact this requires a bugfix release.

[5u623l20]

Ouch. No problem. I have already committed in the tree as an update. Will pick up the next one when released.

[sonertari]

SSLproxy 0.9.10 released

[5u623l20]

Thanks. Will update again tomorrow.