Primerun: Ensure nvidia_icd.json is used #956
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sonic2kk
changed the title
Owner
Author
|
OP confirmed it to work, shellcheck is green. Ready to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix #953.
When
USEPRIMERUNis on, we export several environment variables. But if thenvidia_icd.jsonis not set in the current environment'sVK_ICD_FILENAMES, it will not be able to use the Nvidia GPU. For cases likee this, we should explicitly exportnvidia_icd.json.The fix for this was given by OP in #953 (they informed which environment variable to use), this PR just applies it in the appropriate spot in the code.
This path is not likely to change, and if other custom ones are necessary, a user can manually set these in their STL env variable config file.
Putting this up as a branch in case this fix is not sufficient, and we have to make other changes.