Skip to content

Conversation

@joetoddsonos
Copy link
Collaborator

@joetoddsonos joetoddsonos commented Jun 21, 2022

  • Added linux-arm64 build to project
  • Added darwin-arm64 build to project
  • Fixed RPi0 bug (Illegal Instruction #13)
  • Updated FLAC library to v1.3.4

Closes: #13

@joetoddsonos joetoddsonos self-assigned this Jun 21, 2022
@coveralls
Copy link

coveralls commented Jun 21, 2022

Pull Request Test Coverage Report for Build 2535684959

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 99.029%

Totals Coverage Status
Change from base Build 921259504: 0.0%
Covered Lines: 306
Relevant Lines: 309

💛 - Coveralls

@joetoddsonos joetoddsonos force-pushed the feature/arm64-build branch 2 times, most recently from 1052451 to b8c03b0 Compare June 22, 2022 12:31
@joetoddsonos joetoddsonos force-pushed the feature/arm64-build branch from b8c03b0 to 3831962 Compare June 22, 2022 12:52
@joetoddsonos joetoddsonos mentioned this pull request Jun 22, 2022
@joetoddsonos joetoddsonos changed the title Add support for Linux arm64 Add support for Linux arm64 + Darwin arm64 Jun 22, 2022
@joetoddsonos joetoddsonos marked this pull request as ready for review June 30, 2022 13:28
@joetoddsonos joetoddsonos removed their assignment Jun 30, 2022
Copy link
Contributor

@conorsleithsonos conorsleithsonos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

soundfile is currently broken for Apple Silicon -- see bastibe/python-soundfile#325

FWIW their latest release candidate installs and imports on my machine, but I haven't done any further testing.

It looks like they're close to having a release, but not sure how long that will take to make it to pypi. I will open an issue here linking to the above for visibility, and offer to help them test the new release

@joetoddsonos
Copy link
Collaborator Author

SoundFile 0.11.0 has now been release - https://pypi.org/project/soundfile/0.11.0/

@joetoddsonos joetoddsonos force-pushed the feature/arm64-build branch 2 times, most recently from 53099c7 to f2cb449 Compare September 27, 2022 07:52
@conorsleithsonos conorsleithsonos merged commit fd39d70 into develop Oct 20, 2022
@joetoddsonos joetoddsonos deleted the feature/arm64-build branch October 20, 2022 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Illegal Instruction

4 participants