Skip to content

Custom synthetics #264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
pakrentos merged 110 commits into from
Apr 18, 2023
Merged

Custom synthetics #264

pakrentos merged 110 commits into from
Apr 18, 2023

Conversation

@pakrentos
Copy link
Contributor

@pakrentos pakrentos commented Feb 9, 2023

#846 PR Migration

Changes

  • Added ability to register new synthetic assets tied with symbols provided from oracles. Asset id will be generated by the pallet. It can be found after in the storage or in event.
  • Added separate base fees for every synthetic
  • Added excpetion for USD symbol, because we already have XSTUSD asset
  • Added tests
  • Added benchmarks
  • Added migration

Issue

#134

Blocks

It's kind off blocked by https://github.com/soramitsu/sora2-substrate/pull/829 and it uses band pallet directly for now

Arjentix added 30 commits December 7, 2022 13:12
@Arjentix
Fix bug with double AssetRegistered event
16654c4 
Signed-off-by: Daniil Polyakov <[email protected]>
@Arjentix
Take DataFeed trait from oracle-proxy-pallet branch
c79259a 
Signed-off-by: Daniil Polyakov <[email protected]>
@Arjentix
Allow trading pair registration via method
079d7af 
Signed-off-by: Daniil Polyakov <[email protected]>
@Arjentix
Introduce new extrinsics
14dc823 
Signed-off-by: Daniil Polyakov <[email protected]>
@Arjentix
Merge branch 'develop' into custom_synthetics
87c2fd5
@Arjentix
Add "USD" corner case
4e05c6f 
Signed-off-by: Daniil Polyakov <[email protected]>
@Arjentix
Add asset_symbol and asset_name parameters
da06c1a 
Signed-off-by: Daniil Polyakov <[email protected]>
@Arjentix
Add synthetic asset id generation
1f0daf7 
Signed-off-by: Daniil Polyakov <[email protected]>
@Arjentix
Fix reference_price() to work with all synthetics
b91fd23 
Signed-off-by: Daniil Polyakov <[email protected]>
@Arjentix
Add oracle prices to buy_price()
1b1c2eb 
Signed-off-by: Daniil Polyakov <[email protected]>
@Arjentix
Add oracle prices to sell_price()
01d0e65 
Signed-off-by: Daniil Polyakov <[email protected]>
@Arjentix
Add SyntheticInfo struct
7f0bfe6 
Signed-off-by: Daniil Polyakov <[email protected]>
@Arjentix
Add extrinsics to set fees
60acb34 
Signed-off-by: Daniil Polyakov <[email protected]>
@Arjentix
Implement fees logic
8bcd912 
Signed-off-by: Daniil Polyakov <[email protected]>
@Arjentix
Add fees into enable_synthetic_asset() extrinsic
dfe3f4c 
Signed-off-by: Daniil Polyakov <[email protected]>
@Arjentix
Remove some useless code
1dad40e 
Signed-off-by: Daniil Polyakov <[email protected]>
@Arjentix
Update Config usage in mock and runtime
0a7c8fc 
Signed-off-by: Daniil Polyakov <[email protected]>
@Arjentix
Some fixes to make it all compile
0c85af8 
Signed-off-by: Daniil Polyakov <[email protected]>
@Arjentix
Revert "Implement fees logic"
2e47d6b 
This reverts commit 8bcd912.

Signed-off-by: Daniil Polyakov <[email protected]>
@Arjentix
Make one fee instead of buy and sell fees
6ec0ae4 
Signed-off-by: Daniil Polyakov <[email protected]>
@Arjentix
Fix calculation in reference_price()
a9f5db1 
Signed-off-by: Daniil Polyakov <[email protected]>
@Arjentix
Add tests for new extrinsics
a46da94 
Signed-off-by: Daniil Polyakov <[email protected]>
@Arjentix
Merge branch 'develop' into custom_synthetics
8ce807a 
Signed-off-by: Daniil Polyakov <[email protected]>
@Arjentix
Partly fix benchmarks
7ad8bc3 
Signed-off-by: Daniil Polyakov <[email protected]>
@Arjentix
Move xst pallet benchmarks to a separate crate
1acec10 
Signed-off-by: Daniil Polyakov <[email protected]>
@Arjentix
Finish fixing benchmarks
ae9b741 
Signed-off-by: Daniil Polyakov <[email protected]>
@Arjentix
Update weights
a5fdf5c 
Signed-off-by: Daniil Polyakov <[email protected]>
@Arjentix
Update extrinsics doc comments
d14c109 
Signed-off-by: Daniil Polyakov <[email protected]>
@Arjentix
Add migration
057b2ed 
Signed-off-by: Daniil Polyakov <[email protected]>
@Arjentix
Remove useless LiquidityProxy from xst::Config
b0c5df0 
Signed-off-by: Daniil Polyakov <[email protected]>
@pakrentos pakrentos requested a review from wer1st April 17, 2023 07:42
vovac12
vovac12 reviewed Apr 17, 2023
View reviewed changes
wer1st
wer1st reviewed Apr 17, 2023
View reviewed changes
@pakrentos pakrentos requested review from vovac12 and wer1st April 17, 2023 11:02
wer1st
wer1st reviewed Apr 17, 2023
View reviewed changes
@pakrentos pakrentos requested a review from wer1st April 17, 2023 17:50
wer1st
wer1st reviewed Apr 17, 2023
View reviewed changes
@pakrentos pakrentos merged commit 68bcd20 into develop Apr 18, 2023
@pakrentos pakrentos deleted the custom_synthetics branch April 18, 2023 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wer1st wer1st wer1st approved these changes

@vovac12 vovac12 vovac12 approved these changes

@stefashkaa stefashkaa Awaiting requested review from stefashkaa

@Nikita-Polyakov Nikita-Polyakov Awaiting requested review from Nikita-Polyakov

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

2.0.0 - SORA Synthetics

Development

Successfully merging this pull request may close these issues.

6 participants

@pakrentos @wer1st @vovac12 @Tieumsan @Arjentix