-
Notifications
You must be signed in to change notification settings - Fork 30
remove Zendesk dependency #1730
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Code Climate has analyzed commit b5b4654 and detected 0 issues on this pull request. View more on Code Climate. |
|
Visit the preview URL for this PR (updated for commit da69c11): https://co-reality-staging--preview-pr-1730-h2offbqm.web.app (expires Wed, 21 Jul 2021 07:18:58 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 |
0xdevalias
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ermiaSparkle What about the showZendesk param on Venue + all other related locations?
fixed in 7dfe6d9 |
|
@ermiaSparkle looks like this PR has merge conflicts with |
|
@ermiaSparkle When your pull request is ready for re-review, you should use the button at the top right corner, next to the reviewer's name. |
mike-lvov
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Remove Zendesk
partially fixes https://github.com/sparkletown/internal-sparkle-issues/issues/839
Before


After