Skip to content

Conversation

@ermiaSparkle
Copy link
Contributor

@ermiaSparkle ermiaSparkle commented Jul 6, 2021

@ermiaSparkle ermiaSparkle requested a review from 0xdevalias July 6, 2021 05:46
@ermiaSparkle ermiaSparkle requested a review from a team as a code owner July 6, 2021 05:46
@ermiaSparkle ermiaSparkle temporarily deployed to feature-preview July 6, 2021 05:46 Inactive
@qlty-cloud-legacy
Copy link

qlty-cloud-legacy bot commented Jul 6, 2021

Code Climate has analyzed commit b5b4654 and detected 0 issues on this pull request.

View more on Code Climate.

@github-actions
Copy link

github-actions bot commented Jul 6, 2021

Visit the preview URL for this PR (updated for commit da69c11):

https://co-reality-staging--preview-pr-1730-h2offbqm.web.app

(expires Wed, 21 Jul 2021 07:18:58 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

@ermiaSparkle ermiaSparkle changed the title remove Zendesk remove Zendesk dependency Jul 6, 2021
@ermiaSparkle ermiaSparkle added the 🏎️ performance For performance related issues/improvements label Jul 6, 2021
Copy link
Contributor

@0xdevalias 0xdevalias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ermiaSparkle What about the showZendesk param on Venue + all other related locations?

@ermiaSparkle ermiaSparkle temporarily deployed to feature-preview July 6, 2021 07:48 Inactive
@ermiaSparkle
Copy link
Contributor Author

ermiaSparkle commented Jul 7, 2021

@ermiaSparkle What about the showZendesk param on Venue + all other related locations?

fixed in 7dfe6d9

@0xdevalias
Copy link
Contributor

@ermiaSparkle looks like this PR has merge conflicts with src/pages/VenuePage/VenuePage.tsx now. Can you please fix these up.

@ermiaSparkle ermiaSparkle temporarily deployed to feature-preview July 8, 2021 05:21 Inactive
@ermiaSparkle ermiaSparkle temporarily deployed to feature-preview July 12, 2021 05:45 Inactive
@ermiaSparkle ermiaSparkle temporarily deployed to feature-preview July 13, 2021 06:39 Inactive
@denisdimitrov
Copy link
Contributor

@ermiaSparkle When your pull request is ready for re-review, you should use the button at the top right corner, next to the reviewer's name.

Check № 7
https://docs.github.com/en/github/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/requesting-a-pull-request-review

@ermiaSparkle ermiaSparkle temporarily deployed to feature-preview July 13, 2021 16:38 Inactive
@ermiaSparkle ermiaSparkle requested a review from 0xdevalias July 14, 2021 05:06
@mike-lvov mike-lvov temporarily deployed to feature-preview July 14, 2021 06:54 Inactive
Copy link
Contributor

@mike-lvov mike-lvov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mike-lvov mike-lvov dismissed 0xdevalias’s stale review July 14, 2021 07:03

showZenDesk was removed

@mike-lvov mike-lvov temporarily deployed to feature-preview July 14, 2021 07:03 Inactive
@mike-lvov mike-lvov enabled auto-merge (squash) July 14, 2021 07:05
@mike-lvov mike-lvov disabled auto-merge July 14, 2021 07:14
@ermiaSparkle ermiaSparkle temporarily deployed to feature-preview July 14, 2021 07:14 Inactive
@ermiaSparkle ermiaSparkle temporarily deployed to feature-preview July 14, 2021 07:15 Inactive
@ermiaSparkle ermiaSparkle requested a review from mike-lvov July 14, 2021 07:19
@mike-lvov mike-lvov merged commit 357de1e into staging Jul 14, 2021
@mike-lvov mike-lvov deleted the ermia/remove-Zendesk branch July 14, 2021 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🏎️ performance For performance related issues/improvements 💥 tech-debt

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants