send testtrace function for flare:test command#59
Merged
freekmurze merged 6 commits intomainfrom Nov 28, 2025
Merged
Conversation
freekmurze
reviewed
Nov 24, 2025
Member
freekmurze
left a comment
freekmurze
left a comment
There was a problem hiding this comment.
Nice, start, but can be improved.
Is it possible to also add tests?
src/Flare.php
Outdated
| $this->api->testTrace($trace); | ||
| } | ||
|
|
||
| private function replaceTimestamps(array $data): array |
Member
There was a problem hiding this comment.
In open source, we use protected by default.
src/Flare.php
Outdated
| foreach ($data as $key => $value) { | ||
| if ($key === 'startTimeUnixNano') { | ||
| $data[$key] = $this->time->getCurrentTime(); | ||
| } elseif ($key === 'endTimeUnixNano') { |
Member
There was a problem hiding this comment.
O how I dislike else and elseif.
Could you rewrite this could without those keywords. It will probably end up as being more readable.
I guess you can use early returns.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Accept the test trace and modify its values and send to user