Skip to content

PHP 8.1 Support #809

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 30, 2022
Merged

PHP 8.1 Support #809

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
PHP 8.1 Support 
Backport for #742 & #702
  • Loading branch information
@drecken
drecken authored Aug 29, 2022
commit f51c5bd587947962f1c85cdc0a011304c9e5753c
4 changes: 2 additions & 2 deletions src/QueryBuilderRequest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ public function includes(): Collection

$includeParts = $this->getRequestData($includeParameterName);

if (! is_array($includeParts)) {
if (is_string($includeParts)) {
$includeParts = explode(static::getIncludesArrayValueDelimiter(), $this->getRequestData($includeParameterName));
}

Expand All @@ -53,7 +53,7 @@ public function appends(): Collection

$appendParts = $this->getRequestData($appendParameterName);

if (! is_array($appendParts)) {
if (! is_array($appendParts) && ! is_null($appendParts)) {
$appendParts = explode(static::getAppendsArrayValueDelimiter(), $appendParts);
}

Expand Down