Skip to content

serialize identifier to ld+json @id #102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Gummibeer merged 2 commits into from
Sep 26, 2019
Merged

serialize identifier to ld+json @id #102

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cf1c7f7
serialize identifier to ld+json (at)id
owljester Sep 25, 2019
01dc3ac
fix php cs
Gummibeer Sep 25, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions generator/templates/static/BaseType.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,7 @@ public function offsetUnset($offset)

public function toArray(): array
{
$this->serializeIdentifier();
$properties = $this->serializeProperty($this->getProperties());

return [
Expand Down Expand Up @@ -115,6 +116,14 @@ protected function serializeProperty($property)
return $property;
}

protected function serializeIdentifier()
{
if (isset($this['identifier'])) {
$this->setProperty('@id', $this['identifier']);
unset($this['identifier']);
}
}

public function toScript(): string
{
return '<script type="application/ld+json">'.json_encode($this->toArray(), JSON_UNESCAPED_UNICODE).'</script>';
Expand Down
9 changes: 9 additions & 0 deletions src/BaseType.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,7 @@ public function offsetUnset($offset)

public function toArray(): array
{
$this->serializeIdentifier();
$properties = $this->serializeProperty($this->getProperties());

return [
Expand Down Expand Up @@ -115,6 +116,14 @@ protected function serializeProperty($property)
return $property;
}

protected function serializeIdentifier()
{
if (isset($this['identifier'])) {
$this->setProperty('@id', $this['identifier']);
unset($this['identifier']);
}
}

public function toScript(): string
{
return '<script type="application/ld+json">'.json_encode($this->toArray(), JSON_UNESCAPED_UNICODE).'</script>';
Expand Down
16 changes: 16 additions & 0 deletions tests/BaseTypeTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -308,6 +308,22 @@ public function it_can_be_casted_to_string()

$this->assertEquals($expected, (string) $type);
}

/** @test */
public function it_replaces_identifier_with_at_id_property()
{
$type = new DummyType();

$type->setProperty('identifier', 'object#1');

$expected = [
'@context' => 'https://schema.org',
'@type' => 'DummyType',
'@id' => 'object#1',
];

$this->assertEquals($expected, $type->toArray());
}
}

class DummyType extends BaseType
Expand Down