Skip to content

Change identifier property to id #72

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
cri2net wants to merge 1 commit into from
Closed

Change identifier property to id #72

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Change identifier property to id 
See examples on schema.org e.g. https://schema.org/BreadcrumbList
Also, https://search.google.com/structured-data/testing-tool/ throw error when using "identifier"
  • Loading branch information
@cri2net
cri2net authored Dec 22, 2018
commit a4f629f52555ee103121720818f087243f434a60
2 changes: 1 addition & 1 deletion src/Thing.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ public function disambiguatingDescription($disambiguatingDescription)
*/
public function identifier($identifier)
{
return $this->setProperty('identifier', $identifier);
return $this->setProperty('id', $identifier);
}

/**
Expand Down