-
Notifications
You must be signed in to change notification settings - Fork 14
feat: Changes to generate sdk changelog in releases.md and pr description #229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rated for changelog
mfbx9da4
reviewed
Aug 4, 2025
mfbx9da4
approved these changes
Aug 6, 2025
This reverts commit f94afc6.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Caution
Dont use local packages in go.mod
Revert commit 184fc89
These changes enable the sdk action to use the new SDK changelog in the following places
This feature is currently behind a environment variable ENABLE_SDK_CHANGELOG
Approach
We can take one of 2 types of release/pr/commit message. We decide on the basis of environment flag
SDK_CHANGELOG_JULY_2025.DO NOTE: for terraform we do not use the new format
Currently this SDK changelog is automatically enabled for all repos which have the word
speakeasyin the URL. This is to check and tweak the changelog in for the repos at the following URLsImpact analysis for different permutations of cli and sdk-action
Related PRs
Notes on the PR
The changes in internal/git/git.go are as follows