Skip to content

WIP Harmonize serialization between aiohttp and flask #1095

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
cognifloyd wants to merge 17 commits into from
Closed

WIP Harmonize serialization between aiohttp and flask #1095

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
789f1e9
Support aiohttp handlers to return tuples
Jan 8, 2019
4211f65
Minor update from #828 review
Jan 14, 2019
af8bcb0
Factorize more code between Flask and AioHttp response
Jan 16, 2019
94a684c
Fix CI
Feb 4, 2019
11d05aa
Drop six string types
cognifloyd Dec 4, 2019
c793e42
Standardize response logging
cognifloyd Dec 4, 2019
c77bc4d
Handle one-tuples that only contain data
cognifloyd Dec 4, 2019
2ba9e9a
clean up a couple of type hint comments
cognifloyd Dec 4, 2019
f3e763e
Add a few more get_response tests
cognifloyd Dec 7, 2019
e57e6a6
Adjust _prepare_body interface to simplify improving _serialize_data
cognifloyd Dec 7, 2019
5e9066a
serialize dicts,lists as json when no mimetype is supplied
cognifloyd Dec 6, 2019
619ecc8
deduplicate DEFAULT_MIMETYPE constant
cognifloyd Dec 6, 2019
ac70478
Standardize data serialization
cognifloyd Dec 6, 2019
d49b524
fix aiohttp get_response test and add debug to understand better
cognifloyd Dec 6, 2019
bd3056c
special case for text/plain
cognifloyd Dec 6, 2019
1b141c5
make the default be json
cognifloyd Dec 7, 2019
935533d
update non_str_non_json aiohttp test
cognifloyd Dec 7, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix aiohttp get_response test and add debug to understand better
  • Loading branch information
@cognifloyd
cognifloyd committed Dec 7, 2019
commit d49b5241d748b1e5600cc8128ee31534ef8820ed
2 changes: 2 additions & 0 deletions connexion/apis/abstract.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -447,9 +447,11 @@ def _serialize_data(cls, data, mimetype):
except TypeError:
# or let objects self-serialize
body = str(data)
logger.debug('_serialize_data mimetype=None and str()')
else:
mimetype = DEFAULT_MIMETYPE
else:
logger.debug('_serialize_data mimetype={} and str()'.format(mimetype))
body = str(data)
else:
body = data
Expand Down
5 changes: 2 additions & 3 deletions tests/aiohttp/test_get_response.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,9 +97,8 @@ def test_get_response_from_dict(api):
assert isinstance(response, web.Response)
assert response.status == 200
assert json.loads(response.body.decode()) == {"foo": "bar"}
# get_response does not modify the mimetype or content_type magically. It only simplifies serialization.
assert response.content_type == 'text/plain'
assert dict(response.headers) == {'Content-Type': 'text/plain; charset=utf-8'}
assert response.content_type == 'application/json'
assert dict(response.headers) == {'Content-Type': 'application/json; charset=utf-8'}


@asyncio.coroutine
Expand Down