pass correct content_type to is_json_schema_compatible

[m-nikhil]

Fixes #655
Fixes #860
Related to pull request #760

Changes proposed in this pull request:

• Use correct content_type instead of self.mimetype in is_json_schema_compatible function in decorators/reponse.py

Problem Statement:

• In the case of multiple content_types in spec, response validation assumes incorrect content_type and tries to json_load.

Expected Scenario:

• In the case of multiple content_types in spec, the content_type will be set in the response by the user; else the default application/json will be used.

Solution:

• In is_json_schema_compatible function, the logic rely on self.mimetype which defaults to application/json always.
• The above causes the function to always return True.
• The is_json_schema_compatible must depend on the content_type set by the user.
• The changes made pass content_type to the function and operates the logic on content_type instead of self.mimetype, so returns the correct boolean.

[coveralls]

Coverage remained the same at 96.291% when pulling 00a008e on m-nikhil:master into 96bdcb0 on zalando:master.

[m-nikhil]

@hjacobs @dtkav Can you guys please take a look.

[uniqueg]

Would be very interested to have this merged, or have the issue of dealing with different content types addressed anyhow

[robguinness-snyk]

Any updates on this?

[vmarkovtsev]

Ported as athenianco#10

[m-nikhil]

Bumping it up!
Adding current maintainers, @RobbeSneyders , @Ruwann

[RobbeSneyders]

Thanks @m-nikhil.
Could you rebase on and target this to the v2 branch? We'll cherrypick it to main for v3 later.

[m-nikhil]

Thanks @m-nikhil. Could you rebase on and target this to the v2 branch? We'll cherrypick it to main for v3 later.
@RobbeSneyders , do let me know if it looks good.

[RobbeSneyders]

Thanks @m-nikhil

Two remarks:

• This PR doesn't actually fix How to validate data if swagger-spec has consumer other than 'json' type #655 since that one is about incoming content-types, not response types. It should fix Impossible to return mime type other than application/json if multiple mime types are defined #1500 though. Could you update the description to reflect this?
• Could you add a test for the fixed behavior?

[RobbeSneyders]

Outdated