Skip to content

pass request context to authentication functions #1227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
p4l1ly wants to merge 1 commit into from
Closed

pass request context to authentication functions #1227

p4l1ly wants to merge 1 commit into from

Conversation

@p4l1ly
Copy link
Contributor

@p4l1ly p4l1ly commented Apr 28, 2020

Changes proposed in this pull request:

  • authentication functions might need request context for logging, database access, etc. this pull-request backward-compatibly passes the context to basic auth functions.

@coveralls
Copy link

coveralls commented Apr 28, 2020

Coverage Status

Coverage increased (+0.003%) to 96.295% when pulling 4d47118 on p4l1ly:auth_context into bed4b95 on zalando:master.

@coveralls
Copy link

coveralls commented Apr 28, 2020 •
edited
Loading

Coverage Status

Coverage increased (+0.004%) to 96.296% when pulling 5fc4909 on p4l1ly:auth_context into bed4b95 on zalando:master.

@RobbeSneyders
Copy link
Member

RobbeSneyders commented Apr 1, 2022

This was added in #869.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@p4l1ly @coveralls @RobbeSneyders