Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion connexion/security/async_security_handler_factory.py
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ async def wrapper(request, token, required_scopes):
def verify_security(cls, auth_funcs, required_scopes, function):
@functools.wraps(function)
async def wrapper(request):
token_info = None
token_info = cls.no_value
for func in auth_funcs:
token_info = func(request, required_scopes)
while asyncio.iscoroutine(token_info):
Expand Down
2 changes: 1 addition & 1 deletion connexion/security/security_handler_factory.py
Original file line number Diff line number Diff line change
Expand Up @@ -338,7 +338,7 @@ def wrapper(request, token, required_scopes):
def verify_security(cls, auth_funcs, required_scopes, function):
@functools.wraps(function)
def wrapper(request):
token_info = None
token_info = cls.no_value
for func in auth_funcs:
token_info = func(request, required_scopes)
if token_info is not cls.no_value:
Expand Down
14 changes: 13 additions & 1 deletion tests/decorators/test_security.py
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
import json
import pytest
import requests
from connexion.exceptions import OAuthResponseProblem, OAuthScopeProblem
from connexion.exceptions import OAuthProblem, OAuthResponseProblem, OAuthScopeProblem


def test_get_tokeninfo_url(monkeypatch, security_handler_factory):
Expand Down Expand Up @@ -164,3 +164,15 @@ def apikey_info(apikey, required_scopes=None):
request.headers = {"X-Auth": 'foobar'}

assert wrapped_func(request, ['admin']) is not None


def test_verify_security_oauthproblem(security_handler_factory):
"""Tests whether verify_security raises an OAuthProblem if there are no auth_funcs."""
func_to_secure = MagicMock(return_value='func')
secured_func = security_handler_factory.verify_security([], [], func_to_secure)

request = MagicMock()
with pytest.raises(OAuthProblem) as exc_info:
secured_func(request)

assert str(exc_info.value) == '401 Unauthorized: No authorization token provided'