Skip to content

Fix: Implement smarter reference comparison for i18n #14001

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fix: Implement smarter reference comparison for i18n #14001

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6a64afa
Fix: Implement smarter reference comparison for i18n
dariomesic Oct 28, 2025
22dbaca
Tests: Update intl test to expect new reference warning
dariomesic Oct 28, 2025
2671db1
Merge branch 'master' into fix-i18n-ref-comparison
dariomesic Oct 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Fix: Implement smarter reference comparison for i18n
  • Loading branch information
@dariomesic
dariomesic committed Oct 28, 2025
commit 6a64afad537b064d70ffed406bbfdd0c317d6593
7 changes: 3 additions & 4 deletions sphinx/transforms/i18n.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,10 +135,9 @@ def compare_references(
warning_msg: str,
) -> None:
"""Warn about mismatches between references in original and translated content."""
# FIXME: could use a smarter strategy than len(old_refs) == len(new_refs)
if not self.noqa and len(old_refs) != len(new_refs):
old_ref_rawsources = [ref.rawsource for ref in old_refs]
new_ref_rawsources = [ref.rawsource for ref in new_refs]
old_ref_rawsources = [ref.rawsource for ref in old_refs]
new_ref_rawsources = [ref.rawsource for ref in new_refs]
if not self.noqa and old_ref_rawsources != new_ref_rawsources:
logger.warning(
warning_msg.format(old_ref_rawsources, new_ref_rawsources),
location=self.node,
Expand Down
Loading