Skip to content

Add exception for SVG images #97

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Daltz333 merged 9 commits into from
Feb 9, 2023
Merged

Add exception for SVG images #97

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
02d97ad
Add exception for SVG images
choldgraf Feb 7, 2023
e431e8f
posix to str
choldgraf Feb 7, 2023
8d51b35
Mini svg as well
choldgraf Feb 7, 2023
f02dcb0
Document image svg
choldgraf Feb 7, 2023
0b8bb3a
Lower
choldgraf Feb 7, 2023
d89af9a
Better social image path validation
choldgraf Feb 8, 2023
9c53b2d
Fix test
choldgraf Feb 8, 2023
81bc2e2
Black
choldgraf Feb 8, 2023
6756ae5
Check for None
choldgraf Feb 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
posix to str
  • Loading branch information
@choldgraf
choldgraf committed Feb 7, 2023
commit e431e8f649a8a159d9c9bb5d6e5402e0e66fef61
2 changes: 1 addition & 1 deletion sphinxext/opengraph/socialcards.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -270,7 +270,7 @@ def create_social_card_objects(
axim_mini.imshow(img)

# Put the logo in the top right if it exists
if image and not image.endswith("svg"):
if image and not str(image).endswith("svg"):
img = mpimg.imread(image)
yw, xw = img.shape[:2]

Expand Down