Fix deny-all adapter for socket imports #2971
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Brian H <[email protected]>
lann
reviewed
Dec 19, 2024
Collaborator
lann
left a comment
lann
left a comment
There was a problem hiding this comment.
lgtm but since we paired on the fix another set of eyes would be good
itowlson
approved these changes
Dec 19, 2024
Collaborator
itowlson
left a comment
itowlson
left a comment
There was a problem hiding this comment.
LGTM but since I am as ignorant as apples... grin
Should we do a 3.1 patch for this?
Collaborator
Author
|
Yes a patch makes sense. I can't get to it today but I can cut a release tomorrow morning. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2969