Check allowed hosts before checking the request_interceptor
#3016
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit updates the `request_interceptor` implementation of outbound HTTP requests to check the set of allowed hosts before calling the `request_interceptor`. This fixes behavior in Spin where service-chained requests were allowed regardless of configuration of `allowed_outbound_hosts` in `spin.toml`. A new test is added to ensure that a request to the "back" component is disallowed. Signed-off-by: Alex Crichton <[email protected]>
Collaborator
|
Oof - I'm sure we had this implemented before. Must have been lost in the conversion to factors. |
lann
approved these changes
Feb 19, 2025
itowlson
approved these changes
Feb 19, 2025
Collaborator
itowlson
left a comment
itowlson
left a comment
There was a problem hiding this comment.
Yikes. Thanks for adding the test!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit updates the
request_interceptorimplementation of outbound HTTP requests to check the set of allowed hosts before calling therequest_interceptor. This fixes behavior in Spin where service-chained requests were allowed regardless of configuration ofallowed_outbound_hostsinspin.toml. A new test is added to ensure that a request to the "back" component is disallowed.