This repository was archived by the owner on Dec 20, 2025. It is now read-only.
Add helptext for checkPrecondition expression#1783
Closed
riltsken wants to merge 11 commits intospinnaker:masterfrom
Closed
Add helptext for checkPrecondition expression#1783riltsken wants to merge 11 commits intospinnaker:masterfrom
riltsken wants to merge 11 commits intospinnaker:masterfrom
Conversation
riltsken
force-pushed
the
add-helptext-for-expressions
branch
from
8e1bbd6 to
a79c14e
Compare
Contributor
Author
|
By the way I wanted to add a link to the popover, but the popovers currently disappear when losing focus on the popover trigger element and the fix is some non-trivial event handling which could have an undesired effect. When |
Contributor
|
LGTM - can you rebase against master? We will keep an eye on ui-bootstrap and upgrade to 1.0 when it is released. |
…platformHealthOnlyShowOverride seem to come back as booleans now instead of as strings.
…phase after uniq-ing child nodes for pipeline graph
Added helptext which points to Spring Expression Language so that users understand they can make complex evaluations here.
riltsken
force-pushed
the
add-helptext-for-expressions
branch
from
a79c14e to
61ba264
Compare
Contributor
Author
|
Sorry, messed up this branch. #1784 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added helptext which points to Spring Expression Language so that users understand they can make complex evaluations here.