-
Notifications
You must be signed in to change notification settings - Fork 41
PEX-653: KVStore Versioning Validation #449
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Confirmed with David that the Also check if the ESCU being installed is the same version as the one being tested: |
|
The ESCU testing using this feature branch + the ES 8.3.0 build (splunk_app_es-8.3.0-211918.spl) + CIM 6.3.0 passed: |
| ) | ||
|
|
||
| # Wait for versioning to be activated for ES 8.3.0+ | ||
| if self.kvstore_content_versioning: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this step needed? kvstore versioning should be activated by default; I don't think we need to wait for it to activate
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
According to David, although the kvstore versioning is activated by default, it takes some time for it to be ready. So I added the wait logic here, just to ensure that it's activated successfully (like some time for versioning to setup properly) before searching in kvstore.
From the testing pipeline, the setup time is usually very quick.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That sounds like we're waiting for versioning initialization, not activation, no? Possible I'm not understanding something in the new model, but previously versioning activation was instantaneous, and we were just waiting for the parser to ingest everything
cmcginley-splunk
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approve. We will follow up on the open thread later

Overview
This PR make below changes:
Testing
Note: The reason doesn't test with ES version between 8.0.4 and 8.2.3 is there is known issue with version validation in these versions