Skip to content

Fix tests broken by url parse #212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 1, 2025
Merged

Fix tests broken by url parse #212

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
d47c282
add scheme to provider url for parsing
rrossetti-splunk May 14, 2025
5055586
parse url with scheme to fix acc tests
rrossetti-splunk May 15, 2025
7d7e7fc
url scheme check
rrossetti-splunk May 19, 2025
f321b3b
hasScheme method fix
rrossetti-splunk Jun 26, 2025
033fea0
add tests for providerConfigure function
rrossetti-splunk Jun 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
hasScheme method fix
  • Loading branch information
@rrossetti-splunk
rrossetti-splunk committed Jun 26, 2025
commit f321b3b9527b2086090e024b4e4d8b78ba439b80
6 changes: 3 additions & 3 deletions splunk/provider.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@ package splunk

import (
"net/url"
"strings"
"time"

"github.com/splunk/terraform-provider-splunk/client"
Expand Down Expand Up @@ -153,6 +152,7 @@ func providerConfigure(d *schema.ResourceData) (interface{}, error) {
}

// hasScheme checks if a string has an "://"
func hasScheme(s string) bool {
return strings.Contains(s, "://") // require URL scheme
func hasScheme(providerUrl string) bool {
parsed, err := url.Parse(providerUrl)
return err == nil && parsed.Scheme != "" && parsed.Host != ""
}
Loading