Skip to content

fixed incorrect file extension on ios #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 16, 2019
Merged

fixed incorrect file extension on ios #4

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
10ed770
fixed incorrect file extension on ios
l0stpenguin Oct 15, 2019
8752d1e
Update GMGridViewController.m
l0stpenguin Oct 15, 2019
312a113
Update GMGridViewController.m
l0stpenguin Oct 16, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions src/ios/GMImagePicker/GMGridViewController.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -493,10 +493,13 @@ - (BOOL)collectionView:(UICollectionView *)collectionView shouldSelectItemAtInde
fetch_item.be_progressed = false;
fetch_item.be_finished = true;

if ([dataUTI containsString:@"heic"]) {
NSString *fileName =[asset valueForKey:@"filename"];
NSString *fileExtension = [fileName pathExtension];
if ([fileExtension containsString:@"heic"]) {
CIImage *ciImage = [CIImage imageWithData:imageData];
NSData* data = [[[CIContext alloc] init] JPEGRepresentationOfImage:ciImage colorSpace:CGColorSpaceCreateDeviceRGB() options:@{}];
imageData = data;
fileExtension = @"jpg";
}


Expand All @@ -507,7 +510,7 @@ - (BOOL)collectionView:(UICollectionView *)collectionView shouldSelectItemAtInde
NSString * filePath;
do {

filePath = [NSString stringWithFormat:@"%@/%@.%@", libPath, [[NSUUID UUID] UUIDString], @"jpg"];
filePath = [NSString stringWithFormat:@"%@/%@.%@", libPath, [[NSUUID UUID] UUIDString], [fileExtension lowercaseString]];
} while ([fileMgr fileExistsAtPath:filePath]);

fetch_item.be_saving_img = true;
Expand Down