Fixed android permissions callback #5
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you provide more information on this change ? |
The original plugin did not wait for the request permission callback as denoted in those comments: The methods were later added by cordova (which was not available when the orignal plugin was developed): |
| // This method executes async and we seem to have no known way to receive the result | ||
| // (that's why these methods were later added to Cordova), so simply returning ok now. | ||
| callbackContext.success(); | ||
| callbackContext.success(1); |
There was a problem hiding this comment.
tu aurais pu inverser la logique
if (hasReadPerm) {
...
} else {
...
}
pas besoin du return non plus
| // For now we just have one permission, so things can be kept simple... | ||
| if (grantResults.length > 0 && grantResults[0] == PackageManager.PERMISSION_GRANTED) { | ||
| cordova.startActivityForResult(this, imagePickerIntent, 0); | ||
| callbackContext.success(1); |
There was a problem hiding this comment.
on envoie 1 en cas de succès ? dans le else aussi c'est un cas de succès ?
There was a problem hiding this comment.
oui la method est successful, le 1/0 represente la statue de permission.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.